Skip to content

Move type relations into submodule relate in rustc_infer, and notify when it has changed #118944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 15, 2023
Merged

Move type relations into submodule relate in rustc_infer, and notify when it has changed #118944

merged 4 commits into from
Dec 15, 2023

Conversation

@compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Dec 14, 2023

r? lcnr

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2023
@compiler-errors compiler-errors changed the title Move type relations into submodule in rustc_infer, and notify when it has changed Move type relations into submodulerelate in rustc_infer, and notify when it has changed Dec 14, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2023

Could not assign reviewer from: lcnr.
User(s) lcnr are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

compiler-errors
compiler-errors commented Dec 14, 2023
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with this PR, r=me after fixing CI

@compiler-errors compiler-errors added T-types Relevant to the types team, which will review and decide on the PR/issue. and removed A-meta Area: Issues & PRs about the rust-lang/rust repository itself labels Dec 15, 2023
@rustbot rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Dec 15, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr lcnr changed the title Move type relations into submodulerelate in rustc_infer, and notify when it has changed Move type relations into submodule relate in rustc_infer, and notify when it has changed Dec 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2023

Could not assign reviewer from: lcnr.
User(s) lcnr are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rust-cloud-vms rust-cloud-vms bot force-pushed the relate branch 3 times, most recently from 89f7693 to cd950ca Compare December 15, 2023 17:36
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member Author

compiler-errors commented Dec 15, 2023

ok finally
@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Dec 15, 2023

📌 Commit 0184c76 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 15, 2023
@matthiaskrgr
Rollup merge of rust-lang#118944 - compiler-errors:relate, r=lcnr
f80d5c3 
Move type relations into submodule `relate` in rustc_infer, and notify when it has changed

r? lcnr
This was referenced Dec 15, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
@bors
Auto merge of rust-lang#118996 - matthiaskrgr:rollup-n6x2lc7, r=matth…
a96d57b 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#117824 (Stabilize `ptr::{from_ref, from_mut}`)
 - rust-lang#118234 (Stabilize `type_name_of_val`)
 - rust-lang#118944 (Move type relations into submodule `relate` in rustc_infer, and notify when it has changed)
 - rust-lang#118977 (Simplify `src-script.js` code)
 - rust-lang#118985 (Remove `@JohnTitor` from diagnostics pings)
 - rust-lang#118986 (Simplify JS code a little bit)
 - rust-lang#118988 (rustdoc: add regression test for JS data file loading)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d5213cf into rust-lang:master Dec 15, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 15, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
@rust-timer
Unrolled build for rust-lang#118944
8d2c249 
Rollup merge of rust-lang#118944 - compiler-errors:relate, r=lcnr

Move type relations into submodule `relate` in rustc_infer, and notify when it has changed

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

5 participants

@compiler-errors @rustbot @rust-log-analyzer @bors @lcnr